Removed dead constructor PreferHash #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
reviewed
Jul 29, 2021
| data GenerateHashStrategy | ||
| = ForceHash -- ^ Option @--hash@ given. | ||
| | ForceNoHash -- ^ Option @--no-hash given. | ||
| | PreferNoHash -- ^ None of these option given, default behavior. |
There was a problem hiding this comment.
I think you are right that as far as the hpack executable is concerned this is indeed dead code. However, it is exposed through the API, so as I understand it a user of the API could still use it to force pre-0.34 behavior.
There was a problem hiding this comment.
Ok, so maybe phase this out slowly, or deprecate it in the API first.
The constructor PreferHash of GenerateHashStrategy is never used, removing it clarifies the logic to the reader of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor PreferHash of GenerateHashStrategy is never used,
removing it clarifies the logic to the reader of the code.