-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor: extract solana-pubkey crate from solana-sdk
#3889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: extract solana-pubkey crate from solana-sdk
#3889
Conversation
|
@sonicfromnewyoke is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the crate usage of solana_sdk::pubkey::Pubkey is still being used in some places.
my bad, fixed |
|
@sonicfromnewyoke Could you resolve the conflicts? |
|
@sonicfromnewyoke can you please resolve the merge conflicts? |
f702433 to
5c75543
Compare
|
@jacobcreech sorry, i missed your message... |
|
this CI step fails because CLI generates rust test like follows: // cli/src/lib.rs
pub const VERSION: &str = env!("CARGO_PKG_VERSION");
// cli/sc/rust_template.rs
pub fn tests_cargo_toml(name: &str) -> String {
format!(
r#"[package]
name = "tests"
version = "0.1.0"
description = "Created with Anchor"
edition = "2021"
rust-version = "{msrv}"
[dependencies]
anchor-client = "{version}"
{name} = {{ version = "0.1.0", path = "../programs/{name}" }}
"#,
msrv = ANCHOR_MSRV,
version = VERSION,
name = name,
)
}that results into importing to "fix" it we can use relative path to the client instead of the pinned version. What do you think about it @jacobcreech ? |
This seems fine as it would pass the test after committed. I'll run the tests locally given this PR and see if that's true and then I think we'll be good. |
Motivation
as a part of migration mentioned in #3884
solana-pubkeywas extracted fromsolana-sdkand reexported inanchor-clientalongside withsolana-sdkfor now