chore: Updated Kora signers crate #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 6f661f0 in 39 seconds. Click for details.
- Reviewed
21lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.lock:6852
- Draft comment:
Updated solana-signers commit hash. Ensure compatibility with existing code. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about ensuring compatibility with a commit hash update, which falls under the rule of not asking the PR author to ensure compatibility or test changes. This is not a specific code suggestion or a request for a test, so it should be removed.
2. Cargo.lock:6867
- Draft comment:
Removed 'vaultrs' dependency. Confirm this removal is intentional and safe. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm the intention behind removing a dependency. This violates the rule against asking for confirmation of intention or safety of changes, especially related to dependencies.
Workflow ID: wflow_fn6Y6TmEv6H0pNYX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
solana-signerscrate inCargo.lockand removevaultrsdependency.solana-signerscrate inCargo.lockto commitf98cf96fd451ea4da38c6a425364147a4731fd4d.vaultrsdependency fromsolana-signersinCargo.lock.This description was created by
for 6f661f0. You can customize this summary. It will automatically update as commits are pushed.
📊 Unit Test Coverage
Unit Test Coverage: 80.6%
View Detailed Coverage Report