Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@asmaloney
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.784% when pulling de24de4 on asmaloney:go-module into 5ed3a6d on solher:master.

@solher
Copy link
Owner

solher commented Mar 9, 2021

Thanks! Just one thing, is the Go version limitation really needed?

@asmaloney
Copy link
Contributor Author

I'm new to modules as well and went looking for info about this. It is apparently required and running any go command will try to add it to go.mod if it's not there (e.g. this commit).

Here's Ian's explanation about the version number.

BTW - if this is merged, the repo will also need a new tag so those using modules can point at it.

Thanks Fabien!

@solher
Copy link
Owner

solher commented Mar 9, 2021

Alright let's go then if it should have close to 0 impact :D

@solher solher merged commit 04a30e0 into solher:master Mar 9, 2021
@solher
Copy link
Owner

solher commented Mar 9, 2021

Added a release

@asmaloney asmaloney deleted the go-module branch March 9, 2021 17:11
@asmaloney
Copy link
Contributor Author

Great - thanks for all your work on arangolite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants