feat(space): add event history logging for space state changes #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `SpaceStateEventHistory` model to log detailed event data (source, requested state, duration, etc.). - Updated `open_space` and `close_space` to log events with new model. - Added `SpaceStateSource` enumeration to track event sources (HTTP, Slack). - Refactored HTTP and Slack listeners to pass event source to state change functions.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive event history logging for space state changes by introducing a new database model to track detailed event metadata beyond the simple boolean state history.
Key changes:
- New
SpaceStateEventHistorymodel logs event source, requested state, duration, and state transitions SpaceStateSourceenum differentiates between HTTP and Slack-triggered events- Both
open_spaceandclose_spacefunctions now accept asourceparameter and log events to the new collection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/plugins/space/spacestate/models.py | Adds SpaceStateSource enum and SpaceStateEventHistory document model for event logging |
| src/plugins/space/spacestate/listeners/slack.py | Updates Slack handlers to pass SpaceStateSource.SLACK to state change functions |
| src/plugins/space/spacestate/listeners/http.py | Updates HTTP endpoints to pass SpaceStateSource.HTTP to state change functions |
| src/plugins/space/spacestate/common.py | Implements event history logging function and updates open_space/close_space signatures to accept source parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
refactor: change open_space and close_space signatures from / to * for keyword-only source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpaceStateEventHistoryDB model to log detailed event data (source, requested state, duration, etc.).space_state_event_historyopen_spaceandclose_spacefunctions to log events with new model.SpaceStateSourceenumeration to track event sources (HTTP, Slack).