Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improved space state update logic on state poller #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcorky merged 1 commit into from
May 28, 2024
Merged

Improved space state update logic on state poller #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions smibhid/lib/space_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,22 @@ def set_output_space_none(self) -> None:
def _set_space_state_check_to_error(self) -> None:
"""Activities relating to space_state check moving to error state"""
self.log.info("Space state check has errored.")
self.space_state_check_in_error_state = True
self.state_check_error_open_led_flash_task = create_task(self.space_open_led.async_constant_flash(2))
self.state_check_error_closed_led_flash_task = create_task(self.space_closed_led.async_constant_flash(2))
self.display.print_space_state("Error")
if not self.space_state_check_in_error_state:
self.space_state_check_in_error_state = True
self.state_check_error_open_led_flash_task = create_task(self.space_open_led.async_constant_flash(2))
self.state_check_error_closed_led_flash_task = create_task(self.space_closed_led.async_constant_flash(2))
self.display.print_space_state("Error")

def _set_space_state_check_to_ok(self) -> None:
"""Activities relating to space_state check moving to ok state"""
self.log.info("Space state check status error has cleared")
self.space_state_check_in_error_state = False
self.state_check_error_open_led_flash_task.cancel()
self.state_check_error_closed_led_flash_task.cancel()
self.space_open_led.off()
self.space_closed_led.off()
self._set_space_output(self.space_state)
if self.space_state_check_in_error_state:
self.space_state_check_in_error_state = False
self.state_check_error_open_led_flash_task.cancel()
self.state_check_error_closed_led_flash_task.cancel()
self.space_open_led.off()
self.space_closed_led.off()
self._set_space_output(self.space_state)

def _free_to_check_space_state(self) -> bool:
"""Check that we're not already checking for space state"""
Expand Down Expand Up @@ -119,19 +121,13 @@ async def async_update_space_state_output(self) -> None:
try:
self.log.info("Checking space status from server")
new_space_state = await wait_for(self.slack_api.async_get_space_state(), self.checking_space_state_timeout_s)
self.log.info(f"Space state is: {new_space_state}")
if new_space_state != self.space_state:
self.log.info("Space state changed")
self._set_space_output(new_space_state)

if self.space_state_check_in_error_state:
self.log.info("Space state unchanged")
self._set_space_state_check_to_ok()
self.log.info(f"Space state is: {new_space_state}, was: {self.space_state}")
self._set_space_output(new_space_state)
self._set_space_state_check_to_ok()

except Exception as e:
self.log.error(f"Error encountered updating space state: {e}")
if not self.space_state_check_in_error_state:
self._set_space_state_check_to_error()
self._set_space_state_check_to_error()
raise

finally:
Expand Down