Add module config object for network monitor #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Implement dependency injection in SpaceState __init__ feat: Pass network object to Slack API Wrapper constructor refactor: Update imports for Slack API feat: Implement ModuleConfig class for managing module configurations refactor: Refactor HID class to use ModuleConfig for dependency injection Will need new state handler to consume the updated state This closes #110
samcorky
approved these changes
Jul 2, 2024
Contributor
samcorky
left a comment
There was a problem hiding this comment.
Not sure about this kind of import. I'd rather it be explicitly relative or absolute. Will approve but need to discuss it tomorrow.
Contributor
|
I mean they should really be `from .slack_api import Wrapper` to signify
it's relative. Without the dot, it assumes that `slack_api` is a top level
module or package.
Either it should be `from smibhid.lib.slack_api import Wrapper` or `from .slack_api import Wrapper`
...
For some reason in-line code snippets aren't rendering for me
|
samcorky
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.