Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sjefferson99
Copy link
Member

This closes #134

Copy link
Contributor

@samcorky samcorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting looks off, might just be my mobile view!

@sjefferson99
Copy link
Member Author

Indenting looks off, might just be my mobile view!

@sam57719 The indenting is off on github copy, but fine local, will fiddle with it and get it right.

@sjefferson99
Copy link
Member Author

Indenting looks off, might just be my mobile view!

@sam57719 The indenting is off on github copy, but fine local, will fiddle with it and get it right.

@sam57719 Fixed, but to do so it now renders the whole file as changed, but the change for this PR is shown in the earlier commit I haven't squashed, so this should be good to approve now?

Copy link
Contributor

@samcorky samcorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🤑🫡

@samcorky samcorky self-requested a review July 3, 2024 19:11
@sjefferson99 sjefferson99 merged commit 40ad12a into master Jul 3, 2024
@sjefferson99 sjefferson99 deleted the Add-busy-spinner branch July 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Busy spinner on LCD1602 display

3 participants