feat: Add async UI log uploader to periodically upload UI log to server #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add async method to upload UI log to server periodically in the HID class. This method checks for UI log data, uploads it to the server if necessary, and clears the UI log. Also handles error logging and disabling. This closes #209
Contributor
|
What happens if someone presses closed when it's closed, do we get a log? Assuming not |
Member
Author
|
The log is of button presses not outcomes, so any button press, even if no effect is recorded. Useful for seeing when someone presses a button presumably expecting an output even though it doesn't generate any. |
Contributor
|
@sjefferson99 did you see my comments in the review? |
samcorky
reviewed
Aug 4, 2024
samcorky
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async method to upload UI log to server periodically in the HID class.
This method checks for UI log data, uploads it to the server if necessary,
and clears the UI log. Also handles error logging and disabling.
This closes #209