Add logging feature for space open/close events #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable logging of button press events in Slack plugin for space open/close actions. This includes saving logs to the database and capturing client IP and hostname, along with a stub for testing log inputs.
Removed the debug logging of the entire event object to streamline the code. This reduces unnecessary logging output, improving clarity and efficiency in handling device IPs and hostnames.
…nitial response, which is overridden with a custom one anyway. The issue was with the slack to_bolt_request() call, which didn't like JSON arrays as the top level json element. Changed test log stub to output UTC time
sjefferson99
approved these changes
Aug 10, 2024
Member
sjefferson99
left a comment
There was a problem hiding this comment.
Code structure looks good.
Tested new docker and smibhid elements on my test rig and all works as expected.
Contributor
Author
|
Can you re-approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable logging of button press events in Slack plugin for space open/close actions. This includes saving logs to the database and capturing client IP and hostname, along with a stub for testing log inputs.
Only tested with stubbed data (see tests subdirectory in new plugin)
Data gets logged to:
space_smibhid
smibhid-ui-logs