SMIBHID has a webserver! Closes #248 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcorky
requested changes
Oct 14, 2024
Contributor
samcorky
left a comment
There was a problem hiding this comment.
Code is massive and looks OK, apart from some PEP8 naming convention violations.
I want to test this myself on my own SMIBHID dev board. Probably wont happen until tomorrow or Wednesday.
Member
Author
|
PEP8 issues adjusted. The webserver module is not mine, but I have adjusted enough of it already to take on and continue adjusting things like class names and have adjusted these as well. |
samcorky
reviewed
Oct 14, 2024
Contributor
samcorky
left a comment
There was a problem hiding this comment.
Happy with the PEP8 changes
Contributor
|
@sjefferson99 I want to test this tomorrow/Wednesday before I approve |
Contributor
|
There is a merge conflict - please sort it :) @sjefferson99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.