Add pre-commit and associated dependencies for development workflows
#359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `.pre-commit-config.yaml` with Renovate configuration validator hook. - Update dependencies to include `pre-commit`, `cfgv`, `identify`, `nodeenv`, `virtualenv`, and others. - Organize `pyproject.toml` to include new `dev` dependency group. - Remove `poetry-core` as a dependency.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces pre-commit hooks for development workflow validation, specifically adding a Renovate configuration validator to prevent invalid configuration commits.
- Added pre-commit configuration with Renovate config validation hook
- Reorganized dependencies by creating a dedicated dev dependency group for pre-commit
- Removed poetry-core dependency (likely no longer needed for the build system)
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed poetry-core dependency and added dev dependency group with pre-commit |
| .pre-commit-config.yaml | Added new pre-commit configuration with Renovate validator hook |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sjefferson99
approved these changes
Sep 6, 2025
Member
sjefferson99
left a comment
There was a problem hiding this comment.
Not entirely sure what this does, but have checked it out and been able to build a running smib container set from it.
Contributor
Author
|
This precommit hook, will validate the .github/renovate.json format automatially before allowing the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pre-commit-config.yamlwith Renovate configuration validator hook.pre-commit.pyproject.tomlto include newdevdependency group.poetry-coreas a dependency.Test this by modifying
.github/renovate.json, maybe add a new json object or something - it should block the commit unless you override it