enhance Windows TUN mode#63
Closed
chengxuncc wants to merge 3 commits intosonggao:masterfrom
chengxuncc:master
Closed
enhance Windows TUN mode#63chengxuncc wants to merge 3 commits intosonggao:masterfrom chengxuncc:master
chengxuncc wants to merge 3 commits intosonggao:masterfrom
chengxuncc:master
Conversation
Owner
|
Thanks for the work. As far as I can tell, this is not DHCP. Instead it configures the interface with IP layer along with DNS servers, just like when you manually configure them in the network adapter settings screen. I agree this is useful in many scenarios, though I think it should be in a separate package than the one managing the interface itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
implement #62 with minimal cost