return an error when the expression is incomplete #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Dec 20, 2025
| name: "no unit after prefix P", | ||
| args: args{d: "P6"}, | ||
| want: nil, | ||
| wantErr: true, |
Collaborator
There was a problem hiding this comment.
It's not your fault but the existing unit tests are not able to check if the error returned is the specific one we might expect to have.
Maybe a slight refactoring of this unit tests to call errors.Is is some conditions would help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.
Introduces a new error
ErrIncompleteExprthat is returned if the provided expression is unterminated.It seems we expect the number buffer to be cleared if all terms are properly parsed, and if not - it means that the expression is missing a term.