Support PostgresSQL and SQLServer / Clean go.mod #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01b993f to
0957c7b
Compare
soranoba
commented
Oct 11, 2020
| if len(columns) != len(comparisons) { | ||
| panic("columns and comparisons must have the same length") | ||
| } | ||
| func MakeComparisonScope(columns []string, comparisons []Comparison, nullsOrders []NullsOrder, values []interface{}) func(*gorm.DB) *gorm.DB { |
There was a problem hiding this comment.
breaking changes.
- func MakeComparisonScopeBuildFunc(columns ...string) func(comparisons ...Comparison) func(values ...interface{}) func(*gorm.DB) *gorm.DB`
+ func MakeComparisonScope(columns []string, comparisons []Comparison, nullsOrders []NullsOrder, values []interface{}) func(*gorm.DB) *gorm.DB
soranoba
commented
Oct 11, 2020
| // OrderClauseBuilder returns a function that create ORDER BY clause to specifies the order of DB records. | ||
| func OrderClauseBuilder(columns ...string) func(orders ...Order) string { | ||
| return func(orders ...Order) string { | ||
| func OrderClauseBuilder(columns ...string) func(orders ...string) string { |
There was a problem hiding this comment.
breaking changes
- func OrderClauseBuilder(columns ...string) func(orders ...Order) string
+ func OrderClauseBuilder(columns ...string) func(orders ...string) string
soranoba
commented
Oct 11, 2020
| } | ||
|
|
||
| // ReverseOrders returns a slice of Order converted from ASC to DESC, DESC to ASC. | ||
| func ReverseOrders(orders []Order) []Order { |
There was a problem hiding this comment.
breaking changes
- func ReverseOrders(orders []Order) []Order
+ func ReverseOrders(orders []string) []string
soranoba
commented
Oct 11, 2020
|
|
||
| // Order set the pagination orders, and returns self. | ||
| // The orders must be same order as columns that set to arguments of Paginate. | ||
| func (cursor *Cursor) Order(orders ...pbc.Order) *Cursor { |
There was a problem hiding this comment.
breaking changes
- func (cursor *Cursor) Order(orders ...pbc.Order) *Cursor
+ func (cursor *Cursor) Order(orders ...string) *Cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.