Add a new vsn_format option that controls the format of the app vsn
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
In order to be included in the mainstream of this repository, please explain why it is necessary, what kind of function it is, and create a PR with a minimal diff. |
vsn
Author
|
The added changes have been documented in the PR above. It is fully backward compatible. Please merge, and publish to hex. |
vsnvsn_format option that controls the format of the app vsn
080ce34 to
4427c4f
Compare
* Add a new `{env_key, ignore}` option to ignore modification of the
`env` key, if one is not found in the app file.
* Add a new `{vsn_format, VsnType}` option that controls modification
of the `vsn` key in the app file (default: ignore).
VsnType:
* ignore - no modification
* ggitver - the output of `git describe --always --tags --long`
* gitver - same as above, but the `g` prefix is removed from the
trailing git commit hash
Author
|
Also squashed the PR commits into a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling of cases when the
envkey is not found in the app file.A new
{env_key, ignore}option to ignore modification of theenvkey.Add a new
{vsn_format, VsnFmt}option that controls modificationof the
vsnkey in the app file (default:ignore). This option may be extendedin the future to support additional version formats.
VsnFmt:
ignore- no modificationggitver- the output ofgit describe --always --tags --longgitver- same as above, but thegprefix is removed from thetrailing git commit hash
Fix dialyzer and xref issues - the old code was based on rebar 3.15.0, which was
no longer working with the latest rebar (3.20.0).