properly initialize variable when building IREmitterContext#4535
Merged
properly initialize variable when building IREmitterContext#4535
Conversation
elliottt
approved these changes
Aug 25, 2021
Contributor
Author
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_K6g8rSqhTc3jkr |
jez
approved these changes
Aug 25, 2021
Collaborator
|
I would love to find a compiler flag that makes this into a warning or an error, btw. |
Contributor
Author
This is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We weren't properly initializing this variable along all paths. Luckily (?), not initializing this variable only made the compiler's output less deterministic and also simply made us do a little extra work at runtime.
Test plan
See included automated tests.