Namer pass that never mutates #5470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprocter
reviewed
Mar 14, 2022
Comment on lines
+298
to
+303
|
|
||
| // TODO(jez) This is weird. Is this the first member on noClassOrModule? | ||
| typeMember = enterTypeMember(Loc::none(), Symbols::noClassOrModule(), core::Names::Constants::StubTypeMember(), | ||
| Variance::CoVariant); | ||
| ENFORCE(typeMember == Symbols::StubTypeMember()); | ||
|
|
Contributor
There was a problem hiding this comment.
I dimly recall that I had thought about trying to put this on StubModule but it seemed to run afoul of an ENFORCE while building the initial GlobalState---I don't remember exactly where, and I dimly recall thinking that the failing ENFORCE might actually have been a simple sanity check rather than enforcing a relied-upon property.
You might try moving StubTypeMember somewhere that makes more sense---maybe you'll know how to deal with the breakage (if any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Should unblock work to serve LSP requests from stale data when otherwise it
would have been blocked.
Test plan
Can't really test this yet. We'll likely test in conjunction with #5469.
But that being said, this code is also not used at all yet.