Defer sorting resolver todo lists until it matters #5527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We have a policy of testing changes to Sorbet against Stripe's codebase before Stripe employees can see the build results here: → https://go/builds/bui_LPc3JKc0OR5FTj |
aprocter
approved these changes
Mar 30, 2022
jez
added a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If
tis number of TODO items andeis number of errors, this changes thealgorithm from
O(t log(t))→O(e log(e))tscales with codebase size.ealso scales with codebase size, but muchsmaller, and only for builds that we don't expect to typecheck (branch builds).
Test plan
Hopefully this has no changes, so existing tests should cover this.
I plan to test the perf impact on Stripe's codebaseTimings:
http://go/gist/jez/963ced6034405215ec5530f87ccf5075