VSCode extension: bump vscode-languageclient
#5528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason no-shadow rule does not work with typescript enums
jez
reviewed
Mar 30, 2022
vscode_extension/package.json
Outdated
| "author": "Stripe Inc.", | ||
| "license": "Apache-2.0", | ||
| "version": "0.3.12", | ||
| "version": "0.3.11", |
jez
reviewed
Mar 30, 2022
vscode_extension/package.json
Outdated
Comment on lines
331
to
335
| }, | ||
| "eslintConfig": { | ||
| "rules": { | ||
| "no-shadow": "off" | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we move this into our eslint YAML config file?
jez
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change bumps the
vscode-languageclientpackage. It also required to bump couple of related packages includingtypescriptMotivation
Previous version of the language client didn't support the
codeAction/resolverequest. Here is client capabilities from previous version:{ "codeAction": { "dynamicRegistration": true, "isPreferredSupport": true, "codeActionLiteralSupport": { "codeActionKind": { "valueSet": [ "", "quickfix", "refactor", "refactor.extract", "refactor.inline", "refactor.rewrite", "source", "source.organizeImports" ] } } } }and in the new version
{ "codeAction": { "dynamicRegistration": true, "isPreferredSupport": true, "disabledSupport": true, "dataSupport": true, "resolveSupport": { // I was looking for this property "properties": [ "edit" ] }, "codeActionLiteralSupport": { "codeActionKind": { "valueSet": [ "", "quickfix", "refactor", "refactor.extract", "refactor.inline", "refactor.rewrite", "source", "source.organizeImports" ] } }, "honorsChangeAnnotations": false } }Test plan
See included automated tests.