Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jez
Copy link
Collaborator

@jez jez commented Mar 31, 2022

Motivation

The changes in #5525 raced with a change in Stripe's codebase that caused it to
introduce problems. Blocks can take block arguments, and we don't do a great job
of modeling that right now. It used to be fine because we would just ignore the
error when passing blocks to a .call function on a proc type, because the
procs.rbi file was not # typed: strict

Eventually we might want to make it possible to declare proc types that take
blocks (and for that matter: keyword args) but I'm punting on that for today.

Test plan

See included automated tests.

@jez jez requested a review from a team as a code owner March 31, 2022 18:24
@jez jez requested review from elliottt and removed request for a team March 31, 2022 18:24
@jez jez enabled auto-merge (squash) March 31, 2022 18:25
@jez jez merged commit 2ecb49c into master Mar 31, 2022
@jez jez deleted the jez-procs-rbi branch March 31, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants