Use callLocs in fewer error messages #5551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important because otherwise if there happens to be a block, Sorbet will chunder a huge red line over the whole method call including the block arg if present, which sometimes just makes half the file turn red.
elliottt
approved these changes
Mar 31, 2022
Collaborator
elliottt
left a comment
There was a problem hiding this comment.
Looks good! I like the more precise error locations 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
args.callLocs()contains the block argument, if one exists. Any time weuse this in an error message, it'll chunder across the whole screen, turning
large swaths of it red, obscuring other errors.
Even if there isn't a block, usually there's something more specific that we can
give.
This change searches for a bunch of places where
callLocsis used and stopsusing it.
Test plan
Each commit is arguably an independent change, but given that they're so closely
related in spirit I've made only one PR.
You can review by commit to see the changes to tests next to the relevant change
to calls.cc