Don't insert a duplicate export in the "Apply All" autocorrect in LSP #9818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jez
approved these changes
Jan 9, 2026
| if (exportsAutocorrect.has_value()) { | ||
| allEdits.insert(allEdits.end(), make_move_iterator(exportsAutocorrect->edits.begin()), | ||
| make_move_iterator(exportsAutocorrect->edits.end())); | ||
| } |
Collaborator
There was a problem hiding this comment.
ditto earlier comment about moving as much of this as possible to resolve.
Collaborator
There was a problem hiding this comment.
If you wouldn't mind taking a pass over removing the std:: from this file I would appreciate it.
Comment on lines
+315
to
+316
| std::optional<core::AutocorrectSuggestion> PackageDB::aggregateMissingExportsForFile(const core::GlobalState &gs, | ||
| const core::FileRef fref) { |
Collaborator
There was a problem hiding this comment.
ooc, maybe I'm missing it, but with the import side, there was aggregateMissingImports and aggregateMissingImportsForFile. Why is there not a corresponding symmetry for exports?
a1cf8a0 to
ef0e398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9738 but for exports. The approach is similar, except that it uses
symbolReferencesByFilemap added in #9654.Depends on #9738
Review commit-by-commit.
Motivation
Improve autocorrects.
Test plan
See included automated tests.