Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alphasentaurii
Copy link
Collaborator

@alphasentaurii alphasentaurii commented Aug 26, 2025

Resolves CCD-1636

This PR improves the crds_s3_get script by allowing the user to pass in just the filename (mapping or reference file). The script will determine the exact s3 URI based on the observatory and other environment variables. The destination arg is now an optional argument, and defaults to CRDS_PATH env var. It is still possible to pass in the full s3 uri and absolute path for download destination; these changes allow for a much simpler invocation, e.g. "crds_s3_get roman_0088.pmap".

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
news fragment change types...
  • changes/<PR#>.hst.rst: HST reference files
  • changes/<PR#>.jwst.rst: JWST reference files
  • changes/<PR#>.roman.rst: Roman reference files
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.testing.rst: change to tests or test automation
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@alphasentaurii alphasentaurii requested a review from a team as a code owner August 26, 2025 22:07
Copy link
Collaborator

@hbrown-ST hbrown-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alphasentaurii alphasentaurii merged commit 3ef980a into spacetelescope:master Aug 27, 2025
10 checks passed
@alphasentaurii alphasentaurii deleted the s3-script-updates branch August 27, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants