Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JP-2906: Fix wcs attribute names in wfss_contam step #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2022
Merged

JP-2906: Fix wcs attribute names in wfss_contam step #7028

merged 5 commits into from
Sep 7, 2022

Conversation

@hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Sep 7, 2022 •
edited
Loading

Resolves JP-2906

This PR updates the attribute names for the subarray corner offsets in the WCS transform used in the wfss_contam step for grism images, as described in JP-2906. It should be backwards compatible, by first trying to use the old attribute names and then using the new ones if that fails.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the 8.1.2 milestone Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited
Loading

Codecov Report

Base: 79.72% // Head: 79.67% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (6bc4f58) compared to base (d2a16f1).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7028      +/-   ##
==========================================
- Coverage   79.72%   79.67%   -0.05%     
==========================================
  Files         411      411              
  Lines       37265    37288      +23     
==========================================
  Hits        29708    29708              
- Misses       7557     7580      +23
Flag Coverage Δ *Carryforward flag
nightly 79.70% <71.42%> (ø) Carriedforward from d2a16f1
unit 53.23% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/wfss_contam/disperse.py 56.92% <50.00%> (-31.18%) ⬇️
jwst/wfss_contam/observations.py 57.30% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse requested review from nden and tapastro September 7, 2022 13:58
@hbushouse hbushouse modified the milestones: 8.1.2, Build 8.1.2 Sep 7, 2022
tapastro
tapastro approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@tapastro tapastro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. Required for the recent NIRISS WFSS updates?

Procedurally, maybe I should wait to approve until regtest run is complete... 🤷

@hbushouse
Copy link
Collaborator Author

hbushouse commented Sep 7, 2022

Looks simple enough. Required for the recent NIRISS WFSS updates?

Actually it appears to be an overall change in the way the grism wcs transforms are now setup. The change shows up for both NIRCam and NIRISS WFSS exposures, and the NIRCam updates haven't been merged yet, so I'm guessing it's upstream in the gwcs models somewhere. As soon as I rerun assign_wcs on either a NIRCam or NIRISS WFSS image, the attributes change, even though NIRCam is still using all the old ref files and Cal code.

@hbushouse
Copy link
Collaborator Author

hbushouse commented Sep 7, 2022

Regression test results are here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/417/testReport/

The 6 failures are due to differences from merging #7013 just recently and not getting the truth files updated quickly enough before this test ran. So it's all good.

@hbushouse hbushouse merged commit 66e3f81 into spacetelescope:master Sep 7, 2022
@hbushouse hbushouse deleted the jp-2906 branch September 7, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tapastro tapastro tapastro approved these changes

@nden nden Awaiting requested review from nden

Assignees

No one assigned

Labels

wfss_contam Wide Field Slitless Spec (WFSS)

Projects

None yet

Milestone

Build 8.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@hbushouse @tapastro