Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use log instead of print in tweakreg #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Use log instead of print in tweakreg #7402

merged 2 commits into from
Dec 21, 2022

Conversation

@mcara
Copy link
Member

@mcara mcara commented Dec 19, 2022 •
edited by hbushouse
Loading

This is a simple PR to replace a print statement in the tweakreg step with a log.info(). IMO no changelog is need but let me know if you want me to update the change log.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara requested a review from hbushouse December 19, 2022 20:32
@mcara mcara self-assigned this Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Base: 76.19% // Head: 76.15% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (6e793b9) compared to base (f8cd884).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7402      +/-   ##
==========================================
- Coverage   76.19%   76.15%   -0.04%     
==========================================
  Files         417      417              
  Lines       37984    38139     +155     
==========================================
+ Hits        28942    29046     +104     
- Misses       9042     9093      +51
Flag Coverage Δ *Carryforward flag
nightly 76.17% <0.00%> (ø) Carriedforward from f8cd884
unit 52.06% <0.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/tweakreg/tweakreg_step.py 62.29% <0.00%> (+0.16%) ⬆️
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/model_blender/blendmeta.py 83.05% <0.00%> (-0.71%) ⬇️
jwst/ami/lg_model.py 62.03% <0.00%> (-0.34%) ⬇️
jwst/refpix/irs2_subtract_reference.py 83.97% <0.00%> (-0.30%) ⬇️
jwst/ami/utils.py 87.96% <0.00%> (-0.29%) ⬇️
jwst/ami/nrm_core.py 20.61% <0.00%> (-0.28%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/persistence/persistence.py 80.42% <0.00%> (-0.19%) ⬇️
jwst/transforms/models.py 94.00% <0.00%> (-0.12%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hbushouse
hbushouse reviewed Dec 20, 2022
View reviewed changes
@mcara mcara force-pushed the print-to-log-tweakreg branch from c6a9aa8 to 6e793b9 Compare December 20, 2022 20:34
@hbushouse hbushouse added this to the Build 9.1 milestone Dec 21, 2022
@hbushouse hbushouse merged commit 300c641 into spacetelescope:master Dec 21, 2022
@mcara mcara deleted the print-to-log-tweakreg branch April 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hbushouse hbushouse hbushouse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mcara mcara

Labels

enhancement no-changelog-entry-needed tweakreg

Projects

None yet

Milestone

Build 9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@mcara @hbushouse