Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JP-3864: Move to unified bkg reftype for wfss #9584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 11, 2025
Merged

JP-3864: Move to unified bkg reftype for wfss #9584

merged 7 commits into from
Jul 11, 2025

Conversation

@tapastro
Copy link
Contributor

@tapastro tapastro commented Jun 23, 2025 •
edited by melanieclarke
Loading

Resolves JP-3864

This PR removes usage of the wfssbkg reference file type to the unified bkg reftype, which holds reference backgrounds for both WFSS and SOSS data.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@tapastro tapastro added this to the Build 12.0 milestone Jun 23, 2025
@tapastro tapastro requested a review from a team as a code owner June 23, 2025 16:26
@tapastro
Copy link
Contributor Author

tapastro commented Jun 23, 2025 •
edited
Loading

RTs: https://github.com/spacetelescope/RegressionTests/actions/runs/15829766102

Because CRDS-OPS does not yet have delivered bkg files for NRC_WFSS, I also started a run pointing to CRDS-TEST: https://github.com/spacetelescope/RegressionTests/actions/runs/15829873038

@tapastro tapastro requested a review from a team as a code owner June 23, 2025 16:31
melanieclarke
melanieclarke reviewed Jun 23, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (af59781) to head (f37a218).
⚠️ Report is 438 commits behind head on main.

Files with missing lines Patch % Lines
jwst/background/background_step.py 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #9584   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        367     367           
  Lines      37217   37273   +56     
=====================================
- Misses     37217   37273   +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapastro tapastro marked this pull request as draft June 24, 2025 14:59
@tapastro tapastro modified the milestones: Build 12.0, Build 12.1 Jun 24, 2025
@tapastro
Copy link
Contributor Author

With the change in planned build content, this PR would only further complicate delivery plans, so I'm pushing it to 12.1. Will keep it in draft until the 12.0 release is made.

@tapastro tapastro marked this pull request as ready for review July 2, 2025 19:16
@tapastro tapastro modified the milestones: Build 12.1, 12.0.1 Jul 2, 2025
melanieclarke
melanieclarke reviewed Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@melanieclarke melanieclarke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some updates in the docs. I see references to wfssbkg in:

  • background_step/reference_files.rst
  • references_general/explain_rmaps.rst
  • references_general/references_general.rst

@tapastro tapastro force-pushed the jp-3864-bkg-reftype branch from 3392ca3 to 0c2d1d7 Compare July 9, 2025 18:46
melanieclarke
melanieclarke reviewed Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think. I spotted a couple typos in the docs formatting.

Have you run the regression tests recently?

@tapastro
Copy link
Contributor Author

Docs updated with suggestions, and new RTs started here: https://github.com/spacetelescope/RegressionTests/actions/runs/16204691909

emolter
emolter approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending regtests

@melanieclarke
Copy link
Collaborator

Regtests show the expected header differences for the new reference file type, but also some data differences. Is that expected with the new files?

@tapastro
Copy link
Contributor Author

Regtests show the expected header differences for the new reference file type, but also some data differences. Is that expected with the new files?

Looking at the two files fetched for our RT data, it looks like the files delivered under the bkg reftype may have been misapplied - I see the correct optical path, but the exposure type appears to be "NRC_GRISM" rather than "NRC_WFSS". I've reached out to the NIRCam rep to see if they can confirm it as a bad ref file match.

@tapastro
Copy link
Contributor Author

After talking with Bryan Hilbert, it sounds like there were updated versions of the wfssbkg files delivered for the wide filters, which our RT data falls under. It's not clear from the CRDS delivery messages, but he gave the reference file content changes the okay, so I believe the changes are expected.

@tapastro tapastro requested a review from melanieclarke July 11, 2025 16:02
melanieclarke
melanieclarke approved these changes Jul 11, 2025
View reviewed changes
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for getting this in!

@tapastro tapastro merged commit 8f6458b into spacetelescope:main Jul 11, 2025
28 checks passed
@tapastro
Copy link
Contributor Author

@meeseeksdev backport to release/1.19.x

meeseeksmachine pushed a commit to meeseeksmachine/jwst that referenced this pull request Jul 11, 2025
@tapastro @meeseeksmachine
Backport PR spacetelescope#9584: JP-3864: Move to unified bkg reftype…
97d55ab 
… for wfss
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 11, 2025
Merged
tapastro added a commit that referenced this pull request Jul 11, 2025
@meeseeksmachine @tapastro
Backport PR #9584 on branch release/1.19.x (JP-3864: Move to unified …
8b9c2e3 
…bkg reftype for wfss) (#9638)

Co-authored-by: Tyler Pauly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

@emolter emolter emolter approved these changes

Assignees

No one assigned

Labels

background documentation

Projects

None yet

Milestone

12.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@tapastro @melanieclarke @emolter