Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for slice width calculation #9606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Fix for slice width calculation #9606

merged 2 commits into from
Jun 27, 2025

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jun 26, 2025 •
edited
Loading

Resolves JP-4050

Fix for a crash encountered in cube_build with new-style slice-map-based WCS for NIRSpec IFU.

The issue is that cube_build is looking for a single number, the distance between two slices in slicer coordinates, but it is calculating the value from all valid x and y within the range of two slice bounding boxes + a margin. For G235H, the bounding boxes for the slices checked overlap a little, so there is not a single value returned, but several, corresponding to the unique slice values for multiple slices. Since the code expects only a single value, it crashes.

The fix is to check the slicer value at the center of the slice instead of all pixels in range, which should return a single valid value every time.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 12.0 milestone Jun 26, 2025
@melanieclarke melanieclarke requested a review from jemorrison June 26, 2025 19:34
@melanieclarke
Copy link
Collaborator Author

Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/15910922589

@melanieclarke melanieclarke requested a review from drlaw1558 June 26, 2025 19:39
@codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.48%. Comparing base (c9ff47f) to head (e870874).
⚠️ Report is 430 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9606      +/-   ##
==========================================
- Coverage   80.46%   79.48%   -0.99%     
==========================================
  Files         368      368              
  Lines       37281    37225      -56     
==========================================
- Hits        29997    29587     -410     
- Misses       7284     7638     +354

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

drlaw1558
drlaw1558 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@drlaw1558 drlaw1558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M, and confirmed that this fixes the issue locally for me.

@tapastro
Copy link
Contributor

Is this a rare issue with NIRSpec IFU data, or should it have been seen in our tests? We should consider assessing test coverage in 12.1.

@tapastro tapastro marked this pull request as ready for review June 27, 2025 13:17
@tapastro tapastro requested review from a team as code owners June 27, 2025 13:17
@tapastro tapastro merged commit 7b9b00d into spacetelescope:main Jun 27, 2025
28 of 29 checks passed
@melanieclarke
Copy link
Collaborator Author

Is this a rare issue with NIRSpec IFU data, or should it have been seen in our tests? We should consider assessing test coverage in 12.1.

I think it was grating dependent, and we did not happen to test the WCS change on this grating, either in our regression tests or in the local tests Chris and I independently ran. I'm not sure it would be helpful to have regression tests for all possible grating combinations, but I should have considered testing the change on a wider range of gratings myself, during development.

@melanieclarke melanieclarke deleted the jp-4050 branch June 27, 2025 13:26
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jun 27, 2025
Closed
@tapastro
Copy link
Contributor

@meeseeksdev backport to release/1.19.x

meeseeksmachine pushed a commit to meeseeksmachine/jwst that referenced this pull request Jul 11, 2025
@melanieclarke @meeseeksmachine
Backport PR spacetelescope#9606: Fix for slice width calculation
b47788b
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 11, 2025
Merged
tapastro pushed a commit that referenced this pull request Jul 11, 2025
@meeseeksmachine @melanieclarke
Backport PR #9606 on branch release/1.19.x (Fix for slice width calcu…
f698a90 
…lation) (#9629)

Co-authored-by: Melanie Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jemorrison jemorrison Awaiting requested review from jemorrison

1 more reviewer

@drlaw1558 drlaw1558 drlaw1558 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cube_build

Projects

None yet

Milestone

Build 12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@melanieclarke @tapastro @drlaw1558