Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove schemadoc script #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2025
Merged

remove schemadoc script #9703

merged 4 commits into from
Jul 31, 2025
+1 −67

Conversation

@braingram
Copy link
Collaborator

@braingram braingram commented Jul 25, 2025 •
edited by melanieclarke
Loading

Remove the schemadoc script which currently produces no output.

Closes: #9702

Regression tests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/16527307661

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@braingram braingram mentioned this pull request Jul 25, 2025
Closed
@codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.34%. Comparing base (dfab3b0) to head (9f4c3f6).
⚠️ Report is 276 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9703      +/-   ##
==========================================
+ Coverage   81.26%   81.34%   +0.08%     
==========================================
  Files         368      367       -1     
  Lines       37507    37464      -43     
==========================================
- Hits        30479    30475       -4     
+ Misses       7028     6989      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review July 25, 2025 19:14
@braingram braingram requested review from a team as code owners July 25, 2025 19:14
pllim
pllim reviewed Jul 25, 2025
View reviewed changes
pllim
pllim approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an alternative? Do we need INS blessing? Thanks!

@braingram
Copy link
Collaborator Author

Is there an alternative? Do we need INS blessing? Thanks!

Since it does nothing I guess true is an alternative (faster too!).

@melanieclarke melanieclarke added this to the Build 12.1 milestone Jul 31, 2025
melanieclarke
melanieclarke approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If a similar tool is needed, we can always revive and fix, or build a new one.

@melanieclarke melanieclarke enabled auto-merge July 31, 2025 17:23
@melanieclarke melanieclarke merged commit 5f30154 into spacetelescope:main Jul 31, 2025
28 checks passed
@braingram braingram deleted the remove_schemadoc branch August 4, 2025 13:19
@emolter emolter mentioned this pull request Aug 12, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

@melanieclarke melanieclarke melanieclarke approved these changes

Assignees

No one assigned

Labels

installation testing

Projects

None yet

Milestone

Build 12.1

Development

Successfully merging this pull request may close these issues.

Remove schemadoc script

3 participants

@braingram @pllim @melanieclarke