Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Apr 17, 2025

Resolves RCAL-1055

Closes #1708

This PR adds L1 Average FACE Guide Window File Datamodels, maker utils, & test.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.42%. Comparing base (087a60d) to head (5590eef).
Report is 165 commits behind head on main.

Files with missing lines Patch % Lines
src/roman_datamodels/maker_utils/_datamodels.py 87.50% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   97.56%   97.42%   -0.14%     
==========================================
  Files          30       37       +7     
  Lines        2788     3810    +1022     
==========================================
+ Hits         2720     3712     +992     
- Misses         68       98      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaulHuwe PaulHuwe marked this pull request as ready for review April 17, 2025 16:33
@PaulHuwe PaulHuwe requested a review from a team as a code owner April 17, 2025 16:33
@PaulHuwe
Copy link
Collaborator Author

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit a65dd3d into spacetelescope:main Apr 18, 2025
18 of 20 checks passed
@PaulHuwe PaulHuwe deleted the RCAL-1053_L1GWFace branch April 18, 2025 02:48
PaulHuwe added a commit that referenced this pull request Apr 18, 2025
PaulHuwe added a commit that referenced this pull request Apr 18, 2025
Addendum to approved PR #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants