-
Notifications
You must be signed in to change notification settings - Fork 25
Remove scalar node wrapping and fix DNode/LNode wrapping #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 97.56% 95.03% -2.53%
==========================================
Files 30 41 +11
Lines 2788 4233 +1445
==========================================
+ Hits 2720 4023 +1303
- Misses 68 210 +142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
07e933e to
ebdeb37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Started a fresh regtest run for okifying: https://github.com/spacetelescope/RegressionTests/actions/runs/18497285195 |
|
Merging and okifying the differences. |
Fixes: #581
Fixes: #580
This PR changes how nodes wrap/unwrap values:
m.metatom.metaleads to validation errors #581)With the PR old models can be made:
However if a user modifies an old model they will need to wrap values.
Regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/18410870474
show 11 differences all from tag differences for
meta.filenamewhere:meta.filenameis now the expectedstrmeta.filenameis the type that was provided as an input. As we have some uncal files withFilenameinstead ofstr. I suggest that we regenerate the regtest files. Perhaps we want to wait until we ferret out a few more tagged node uses in romancal. However if that work takes longer than review of this PR I suggest we regenerate the files with this PR.Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change