Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RCAL-1125: Generate SI Cosmos and Point Source Catalog #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
Oct 23, 2025
Merged

RCAL-1125: Generate SI Cosmos and Point Source Catalog #1978

merged 79 commits into from
Oct 23, 2025

Conversation

@PaulHuwe
Copy link
Collaborator

Resolves RCAL-1125

Closes #1876

This PR adds a method to generate cosmos galaxies and point sources for source injection.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.skycell.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

PaulHuwe added 30 commits October 12, 2023 19:29
@PaulHuwe
Removed err array from dark tests.
48eabb0
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
f97e4b3
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
98bdc8d
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
6ea75d8
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
8094e9a
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
2215413
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
8deb17f
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
d9fd901
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
fd2cf46
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
f6a5178
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
506dfe9
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
c2247b8
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
6ab8a67
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
c40ecc6
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
9faf558
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
f87f741
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
9771d92
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
c734961
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
8609e5c
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
18a6744
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
bb4d7e5
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
d0b5f1b
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
333553c
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
60e8104
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
3291903
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
68e2415
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
ddb5239
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
0d26233
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
883487b
@PaulHuwe
Merge branch 'main' of https://github.com/spacetelescope/romancal
c8db3ca
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Sep 27, 2025
Closed
@PaulHuwe PaulHuwe marked this pull request as ready for review September 27, 2025 23:07
@PaulHuwe PaulHuwe requested review from a team as code owners September 27, 2025 23:07
schlafly
schlafly reviewed Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comments in line. The galaxy sizes look wonky to me; I've updated the doc to be more explicit there and have a specific suggestion.

Comparing with the doc, Harry also requested a uniform distribution in sersic indices from 0.8 to 4.5, and we also wanted the positions to be from a grid covering the image. But otherwise this covers the source distributions closely, thanks!

@PaulHuwe PaulHuwe marked this pull request as draft September 30, 2025 23:34
@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Oct 8, 2025

Note: the grid work is in a separate issue - #1877

schlafly
schlafly reviewed Oct 8, 2025
View reviewed changes
@PaulHuwe PaulHuwe requested a review from schlafly October 9, 2025 18:41
@PaulHuwe PaulHuwe marked this pull request as ready for review October 10, 2025 21:53
schlafly
schlafly reviewed Oct 13, 2025
View reviewed changes
@PaulHuwe PaulHuwe requested a review from schlafly October 22, 2025 20:01
schlafly
schlafly approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all looks good to me. Can you remind me how we're handling the romanisim dependency right now? i.e., we don't want romancal to actually depend on romanisim until the stpsf dependency is removed, I think, and I see it commented out in the romancal/main pyproject.toml, but I don't immediately see how these tests can run without it.

@PaulHuwe
Copy link
Collaborator Author

Presently, we just skip tests that rely on RSIM if RSIM is not in the environment:
https://github.com/spacetelescope/romancal/blob/main/romancal/source_catalog/tests/test_injection.py#L7

@schlafly
Copy link
Collaborator

Great.

@schlafly schlafly merged commit 6fe41fe into spacetelescope:main Oct 23, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

26Q1_B20

Development

Successfully merging this pull request may close these issues.

Generate SI Catalog

2 participants

@PaulHuwe @schlafly