Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RCAL-1118 Record aperture corrections in catalog headers #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

RCAL-1118 Record aperture corrections in catalog headers #1911

merged 3 commits into from
Aug 28, 2025

Conversation

@WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Aug 26, 2025 •
edited by nden
Loading

…ile, save those fractions in the table metadata, and update the is_extended property to use the ee_fraction values

Resolves RCAL-1118

Closes #

This PR reads the ee_fractions from the apcorr reference file and then computes the ee_fractions used by the pipeline. These values are then stored in the header of the source_catalog table.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.skycell.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@codecov
Copy link

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.94%. Comparing base (7cad2dc) to head (3f34319).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
romancal/source_catalog/aperture.py 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
+ Coverage   79.85%   79.94%   +0.08%     
==========================================
  Files         137      137              
  Lines        8121     8161      +40     
==========================================
+ Hits         6485     6524      +39     
- Misses       1636     1637       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

schlafly
schlafly reviewed Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

I forget how we propagate the is_extended results from the single band catalogs to the multiband catalogs; can you look at the impact there?

I would remove the fall-back code that exists if aperture reference files aren't available. I don't think we ever want to use the made-up value of 1.4, and should just error out in that case. Is the fall-back needed for testing or something? In which case, maybe we need to be able to provide a dummy spline in the testing, e.g. lambda x: 0?

@WilliamJamieson
Copy link
Collaborator Author

If you want the fall back code removed should I add a kill condition to the step if we cannot find the reference file?

@schlafly
Copy link
Collaborator

I feel like we should handle this as any other missing reference file would be handled; I think that would probably just end with some long traceback?

WilliamJamieson
WilliamJamieson commented Aug 27, 2025
View reviewed changes
@WilliamJamieson
Update the source catalog to use the ee_fraction from the reference f…
f6e5e11 
…ile, save those fractions in the table metadata, and update the is_extended property to use the ee_fraction values
@WilliamJamieson
Update multiband catalog with new ee_fractions metadata
b8a4b7a
WilliamJamieson
WilliamJamieson commented Aug 27, 2025
View reviewed changes
WilliamJamieson
WilliamJamieson commented Aug 27, 2025
View reviewed changes
@WilliamJamieson WilliamJamieson marked this pull request as ready for review August 27, 2025 18:44
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner August 27, 2025 18:44
@WilliamJamieson
Copy link
Collaborator Author

Regression tests fail because now the apcorr_ref files are now being used. https://github.com/spacetelescope/RegressionTests/actions/runs/17274571247/job/49027958580

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner August 27, 2025 18:47
schlafly
schlafly approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks William.

@schlafly schlafly merged commit c8184d6 into spacetelescope:main Aug 28, 2025
24 checks passed
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Aug 28, 2025
@WilliamJamieson @mairanteodoro
RCAL-1118 Record aperture corrections in catalog headers (spacetelesc…
b1760ee 
…ope#1911)
@WilliamJamieson WilliamJamieson deleted the refactor/catalog branch August 28, 2025 14:01
This was referenced Sep 5, 2025
Closed
Closed
@schlafly schlafly mentioned this pull request Oct 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamJamieson @schlafly