Don't read Python env unless it is installed #13589
Conversation
|
It could be beneficial to warn users in some way if we are activating a partially installed / incomplete environment: $ spack env activate ...
==> Warning: the environment is only partially installed and as such it might be inconsistent with the requests in spack.yaml. Run `spack install` to complete its installation and reactivate it.
$Suggestions for better wording are welcome, the idea being to let users know when an environment is not yet ready to be used (this was the case here with |
|
I actually think spack should be more proactive here and offer to do the |
|
I agree that trying to activate a partially installed environment should elicit a warning, but this PR is more general than that. The issue arises when any Spack Environments command is run, including |
Do you mean in another PR or in another place in the code? For the PR, I'm fine with both cases. This PR fixes a bug - and it's not only about The message is related to this in the sense that the issue arise when some of the specs in the environment are not already installed. It can be implemented independently though. My preference would be to have the warning message in this PR along with some regression test, but I'm fine if people want to merge this PR first and fast. |
Feel free to add commits to this PR 😄 |
Will try to do tomorrow |
|
Opened #13675 to keep track of the other modifications I was suggesting here. Merging this as is. |
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
Fixes #13529
Fixes #13509
@becker33 @alalazo feel free to push additional commits to this if you want to add unit tests or modify the behavior. I've been using this for a few days now without any unintended side-effects.