Allow to have "string" ports #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyho me again 👋
Currently it is only possible to provide integer ports to docker (because of the typehint). But other valid ports can contain the ip address / subnet.
For example, those are all valid ports:
So, I've removed the
inttypehint and replaced it with a docblock, which allows both string and int. When this package drops PHP 7.4 support in the future, the docblock can be replaced with a union type:I've added another test to verify that everything is still working. Since integers still work fine, I believe this isn't a breaking change. If you need anything else for die PR, feel free to ask 👍
Thank you!