Add class to manage docker networks #42
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyho,
this is my first draft for a class which manages docker networks. With this you can create, remove and check for existance.
I've tried to let the two classes feel quite similar.
Usage:
Of course, all of the regular stuff, like changing remote host or setting optional arguments are still in there. Maybe we could refactor it, so that we have a trait which holds the same variables / methods which both uses. But I didn't want to do to much work, in case you don't want this in your package :-)
What I removed though is the ability to create a class instance with a static method, like
DockerNetwork::create(……). The problem is, thecreatemethod creates the real network in docker and I couldn't come up with a better name for it.Do you have any ideas?
Thanks in advance! If you don't want this in your package or if I need to something else, please let me know. I've added the README sections and tests.
Related to #18