Support changing execute timeout
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
reviewed
May 4, 2023
Member
freekmurze
left a comment
There was a problem hiding this comment.
Thanks! A few remarks / questions
| @@ -0,0 +1,22 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
Member
There was a problem hiding this comment.
We don't use strict types anywhere. Could you remove this line?
Author
There was a problem hiding this comment.
Happy to remove, I was just following the pattern you already had in tests/DockerContainerTest.php
|
|
||
| public array $commands = []; | ||
|
|
||
| protected float $startCommandTimeout = 60; |
Member
There was a problem hiding this comment.
Where is this value actually being used?
Author
There was a problem hiding this comment.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute()method that enables a custom timeout to be set.setStartCommandTimeout()to enable custom timeout to be set on the start commandTest cases added and README updated.