Add function to get the "docker inspect" information #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove the newline (trim) at the end of the output of getDockerIdentifier().
Member
|
Could you also update the readme where you show how to use the function and what the output is? |
Contributor
Author
|
Updated the readme. |
freekmurze
requested changes
Jun 20, 2022
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have the docker inspect information. This is easily possible with the macro thing, but I figured others might want this as well.
While creating a test I found that getDockerIdentifier() has the identifier with a newline at the end. The test did not like that. Fixed that as well.