Keep order of generic args (fixes #400) #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I avoided touching some helper functions ( |
oscartbeaumont
approved these changes
Oct 29, 2025
|
I think that would be a good idea. I would suspect in most cases the number of generics would be low so the vector operations would probably faster or as fast as the map operations. Thanks for this PR! I am happy to merge it but will wait if you want to push those extra fixes! |
|
Yeah, I kept thinking about it after I opened the PR and also concluded that switching those helpers is clearly the right thing to do. Don't merge yet, I'll make the change. |
This is a breaking change to public interface (Reference::generics, Reference::generics_mut), but I think it's justified (returning HashMap there was misleading).
…shMap This means a lookup will now require a linear scan, but it should be fine because we don't expect too many generic args.
fb6c1f0 to
9e7d719
Compare
|
Done! |
oscartbeaumont
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to public interface (Reference::generics,
Reference::generics_mut), but I think it's justified
(returning HashMap there was misleading).