Call OpenFile instead of Open in CacheOnReadFs (fixes #193)#332
Merged
0xmichalis merged 1 commit intospf13:masterfrom Jan 5, 2022
pojntfx:master
Merged
Call OpenFile instead of Open in CacheOnReadFs (fixes #193)#3320xmichalis merged 1 commit intospf13:masterfrom pojntfx:master
OpenFile instead of Open in CacheOnReadFs (fixes #193)#3320xmichalis merged 1 commit intospf13:masterfrom
pojntfx:master
Conversation
|
|
0xmichalis
approved these changes
Jan 5, 2022
messikiller
pushed a commit
to messikiller/afero
that referenced
this pull request
Apr 8, 2025
Call `OpenFile` instead of `Open` in `CacheOnReadFs` (fixes spf13#193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #193 by calling
OpenFileinstead ofOpenwhen appropiate, thus passing i.e.O_CREATEto the layer. Already tested in https://github.com/pojntfx/stfs.