This repository was archived by the owner on Mar 31, 2022. It is now read-only.
Basic support for using kubernetes passwords using the OpenShift client #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient. Supports current context only at the moment
|
Thanks for the PR. Do you happen to know if openshift support for a registry push can also be achieved by configuring docker, either by editing config.json or a credentials helper? The latter is the path we have been taking recently to add support for other registry providers, to avoid needing to add code for each new provider/API/tool into the plugin directly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification simply calls
oc whami -tto get the kubernetes API token (which also is used for the internal docker registry authentication) and uses that for the users password when the associated server entry in the maven settings has a password of 'oc'.Documentation and multiple context support to follow