Use columns defined for COPY to Redshift so we never rely on order #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlstadther
requested changes
Oct 2, 2017
luigi/contrib/redshift.py
Outdated
| source=f, | ||
| creds=self._credentials(), | ||
| options=self.copy_options) | ||
| ) |
There was a problem hiding this comment.
Perhaps you could do something more like below to reduce duplicate code
colnames = ''
if len(self.columns) > 0:
colnames = ",".join(x[0] for x in self.columns])
cursor.execute("""\
copy {table} {cols} from '{source}'
credentials '{creds}'
{options}
;""".format(
table=self.table,
colnames='({})'.format(colnames),
source=f,
creds=self._credentials(),
options=self.copy_options
)|
I'm going to pull this branch down and verify its compatibility with my ETLs (as i'm not familiar with the data mapping options with COPY). Will report back soon |
|
Thanks, I don't think it should break anything, unless you have defined the columns there but are reliant on it importing them out of order, and I can't really think of any use case where that is desirable. |
dlstadther
approved these changes
Oct 2, 2017
|
Thanks @jamesmcm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue #2244
Motivation and Context
Right now COPYs to Redshift are dependent upon the column ordering which can break imports.
Have you tested this? If so, how?
I've tested it locally with our columns defined.