Handle multiprocessing with request sessions #2290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich is not safe. I believe this is the cause of the reported ``` RPCError: Received null response from remote scheduler ```
dlstadther
approved these changes
Nov 20, 2017
|
Added a basic test @dlstadther |
|
I've wanted to hunt down this bug for a long time! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When luigi forks with
--workersit uses the same requestsSessionobject leading to bugs.Description
Sessionis not multiproc safe. It uses http keep alives, and re-using the session across procs can lead to weird multiplexing. This was the cause of my RPCErrors, from what I can tell.Motivation and Context
Relates to #2209
Have you tested this? If so, how?
I ran under load, 50 workers with and without the fix. With the fix I no longer get the
RPCErrors