Add configuration to enable/disable the pause button #2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Would you mind at least make an API-unittest even if you don't have a unittest for the UI part? |
|
Thanks. Hopefully one day (in far distant future) we'll have proper ACLs and stuff. :) |
alanxu00
pushed a commit
to Affirm/luigi
that referenced
this pull request
Jan 18, 2024
alanxu00
pushed a commit
to Affirm/luigi
that referenced
this pull request
Jan 18, 2024
alanxu00
added a commit
to Affirm/luigi
that referenced
this pull request
Jan 19, 2024
Add configuration to enable/disable the pause button (spotify#2399)
alanxu00
added a commit
to Affirm/luigi
that referenced
this pull request
Jan 19, 2024
* Add configuration to enable/disable the pause button (spotify#2399) * bump version to 2.7.5+affirm.1.4.7 --------- Co-authored-by: Kevin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new config value which, when set to false, will turn disable the functionality of the pause/unpause RPC methods and also hide the pause toggle from the visualiser.
Motivation and Context
We wish to have the ability to disable this functionality because curious engineers may click the button without knowing what it does and accidentally pause all tasks.
Have you tested this? If so, how?
I ensured that when the config is set to false, the button is hidden from the visualiser.