bugfix bigquery bulk complete failing when argument is a generator #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug that prevents BigQuery tasks from working as ranged tasks (RangeDaily, et. al.) in python 3.
Motivation and Context
RangeDaily tasks are broken for big query tasks in python3, because the big query bulk_complete method is invoked, with the return value of a call to map, as an argument. In python 3, map returns a generator, while in python 2 it returns a list.
The MixinBigQueryBulkComplete.bulk_complete method invokes len() on this argument, and so fails if that argument is a generator.
Have you tested this? If so, how?
Current unit tests pass for me.