Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Avro 1.8-compatible APIs in BigQueryType macro #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clairemcginty merged 1 commit into from
Feb 26, 2025
Merged

Use Avro 1.8-compatible APIs in BigQueryType macro #5616

clairemcginty merged 1 commit into from
Feb 26, 2025

Conversation

@clairemcginty
Copy link
Contributor

@clairemcginty clairemcginty commented Feb 26, 2025 •
edited
Loading

macros compiled using Avro 1.8 w/ latest Scio snapshot fail with:

[error] /Users/clairem/spotify-scio-2/elitzur-internal-scio/src/test/scala/com/spotify/elitzur/ElitzurValidationTest.scala:134:4: multiple constructors for Field with alternatives:
[error]   (x$1: String,x$2: org.apache.avro.Schema,x$3: String,x$4: Object,x$5: org.apache.avro.Schema.Field.Order)org.apache.avro.Schema.Field <and>
[error]   (x$1: String,x$2: org.apache.avro.Schema,x$3: String,x$4: Object)org.apache.avro.Schema.Field <and>
[error]   (x$1: String,x$2: org.apache.avro.Schema,x$3: String,x$4: org.codehaus.jackson.JsonNode,x$5: org.apache.avro.Schema.Field.Order)org.apache.avro.Schema.Field <and>
[error]   (x$1: String,x$2: org.apache.avro.Schema,x$3: String,x$4: org.codehaus.jackson.JsonNode)org.apache.avro.Schema.Field
[error]  cannot be invoked with (String, org.apache.avro.Schema)
[error]   @BigQueryType.toTable
[error]    ^

solution: use Field constructor that exists across Avro versions

@clairemcginty clairemcginty requested a review from kellen February 26, 2025 16:28
@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.33%. Comparing base (b5979af) to head (721ded7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5616      +/-   ##
==========================================
- Coverage   61.33%   61.33%   -0.01%     
==========================================
  Files         314      314              
  Lines       11255    11257       +2     
  Branches      802      782      -20     
==========================================
+ Hits         6903     6904       +1     
- Misses       4352     4353       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit d306bdb into main Feb 26, 2025
11 checks passed
@clairemcginty clairemcginty deleted the use-avro-1.8-apis branch February 26, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kellen kellen kellen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clairemcginty @kellen