Add collect method to SCollectionWithSideInput #5666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5666 +/- ##
==========================================
+ Coverage 61.31% 61.47% +0.15%
==========================================
Files 314 314
Lines 11279 11324 +45
Branches 815 801 -14
==========================================
+ Hits 6916 6961 +45
Misses 4363 4363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scio-core/src/test/scala/com/spotify/scio/values/SCollectionWithSideInputTest.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Claire McGinty <[email protected]>
… of github.com:spotify/scio into ctan/SCIO-5533/add-collect-to-SCollectionWithSideInput
charles-tan
commented
Apr 7, 2025
Comment on lines
+37
to
+41
| trait SideInputDoFnWithResource[T, U, R] extends DoFnWithResource[T, U, R] with NamedFn { | ||
| def sideInputContext(c: DoFn[T, U]#ProcessContext, w: BoundedWindow): SideInputContext[T] = | ||
| // Workaround for type inference limit | ||
| new SideInputContext(c.asInstanceOf[DoFn[T, AnyRef]#ProcessContext], w) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Curious what you think about adding an additional trait here. I couldn't create classes such as MapFnWithWithResource extends DoFnWithResource with SideInputDoFn because SideInputDoFn extends NamedDoFn andDoFnWithResource is not a subclass of NamedDoFn.
Contributor
clairemcginty
left a comment
There was a problem hiding this comment.
nice! appreciate the thorough tests!
scio-core/src/main/scala/com/spotify/scio/values/SCollectionWithSideInput.scala
Outdated
Show resolved
Hide resolved
scio-core/src/main/scala/com/spotify/scio/values/SCollectionWithSideInput.scala
Outdated
Show resolved
Hide resolved
…thSideInput.scala Co-authored-by: Claire McGinty <[email protected]>
… of github.com:spotify/scio into ctan/SCIO-5533/add-collect-to-SCollectionWithSideInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5533
Adds
collectmethod toSCollectionWithSideInput.