Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@charles-tan
Copy link
Contributor

Fixes #5767

@charles-tan charles-tan self-assigned this Sep 26, 2025
@charles-tan charles-tan changed the title Fix serialization error with sortMergeCoGroup secondary keys Fix serialization error when sortMergeCoGroup has secondary keys Sep 26, 2025
@charles-tan charles-tan requested a review from shnapz September 26, 2025 22:11
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.56%. Comparing base (052729e) to head (f97ba9f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../smb/syntax/SortMergeBucketScioContextSyntax.scala 22.22% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5768      +/-   ##
==========================================
+ Coverage   61.44%   61.56%   +0.11%     
==========================================
  Files         314      314              
  Lines       11334    11343       +9     
  Branches      807      807              
==========================================
+ Hits         6964     6983      +19     
+ Misses       4370     4360      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kellen kellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@charles-tan charles-tan merged commit c18f7e6 into main Sep 29, 2025
25 of 34 checks passed
@charles-tan charles-tan deleted the ctan/issue-5767/bugfix-sortMergeCoGroup-secondary-keys branch September 29, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using sortMergeCoGroup with secondary key throws NotSerializableException

4 participants