Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sanzmauro
Copy link
Contributor

SPLIT DAEMON

What did you accomplish?

  • Implemented none impression mode
  • Implemented Toggle impressions

@sanzmauro sanzmauro self-assigned this Jan 8, 2025
mredolatti
mredolatti previously approved these changes Jan 17, 2025
@sonarqube-pull-requests
Copy link

Copy link

@EmilianoSanchez EmilianoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanzmauro , not related to this specific feature, but the s field of the SplitView payload, i.e., the list of treatments, is returning duplicated treatment values.

Example for FF test_split with SDK key jksn1abebskvo510phc5lnjf9ubcgoe43rkc:

{
s: 1,
p: {
n: 'test_split',
t: 'user',
k: false,
s: [
'on', 'off', 'other',
'on', 'off', 'other',
'on', 'off', 'other',
'on', 'off', 'other'
],
c: 1669917927035,
f: {},
d: 'off',
e: []
}
}

I guess the issue might be in the append call in this line:
https://github.com/splitio/splitd/blob/SDKS-9120-impressoion-per-toggle/splitio/sdk/sdk.go#L295
Duplicated items should be removed, for example, by appending the values in a set and then converting the set into the s list.

@sanzmauro sanzmauro merged commit fedbf07 into main Jan 28, 2025
4 checks passed
@sanzmauro sanzmauro deleted the SDKS-9120-impressoion-per-toggle branch January 28, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants