Added Line Separator Override Feature to ExtractedTextFormatter #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about #1913
Changes
Added the ability to override the Line Separator in ExtractedTextFormatter. The default remains System.lineSeparator() to ensure backward compatibility.
Background
Relying on System.lineSeparator() has caused unexpected behavior in different environments. Specifically, while PDF files generally use \n as a line separator regardless of the operating system, Windows environments use \r\n as the default System.lineSeparator(). This discrepancy could lead to formatting failures.
My Thoughts
I reviewed related issues and noticed that Line Separator behavior varies significantly depending on the operating system and environment.
To provide a flexible solution that maintains backward compatibility, I implemented an override option to let developers customize the Line Separator based on their needs.
If you have other better ideas, I’d love to discuss them together.